-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier/utm/off_nominal_planning] Add 'down USS with equal priority conflicts not permitted' scenario validating SCD0010 #383
Conversation
…ority conflicts not permitted' scenario validating SCD0010
When a test suite is not provided a resource required by a particular test scenario, that test scenario is skipped. But, note that failing to provide a resource required by a test suite will result in an error. To mark a test suite resource as optional, just suffix it with |
Additionally @BenjaminPelletier I've updated the suite configuration to make the intents optional. If you could have a look at those changes to validate that this is what you were expecting. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- one comment, though I think it can be addressed in a future PR.
monitoring/uss_qualifier/scenarios/astm/utm/off_nominal_planning/down_uss.md
Show resolved
Hide resolved
…ority conflicts not permitted' scenario validating SCD0010 (#383) * [uss_qualifier/utm/off_nominal_planning] Add 'down USS with equal priority conflicts not permitted' scenario validating SCD0010 * set resource as optional to enable skipping test * [mock_uss/f3548] add check for priority allowed in locality; use CHE locality in CI * revert default mock USS locality * setup f3548 suite for optional preemption flight intents * revert mistake * revert 2nd mistake * update resource configuration * revisit naming of flight intents 44be7a7
This scenario, which only applies when the local regulation does not allow equal priority conflicts at the highest level, is built on top of the SCD0005 scenario, which see its implementation slightly refactored in this PR (and has a few cosmetic enhancements)
Do note:
given that this scenario inherits from the SCD0005 scenario, this PR depends on [uss_qualifier] Make scenario doc cache attribute name depend on scenario name #382 for the CI to passdonein the configuration of the F3548 suite I've included this scenario, and I've left a TODO there to remember to include the mechanism enabling the test designer to skip it. I've done so because I was not sure how to do that properly. I will happily update this PR if I have some pointers/examples, otherwise that can be left for the future. Up to the reviewer.updatedthis PR contains [mock_uss/f3548] Add check for priority allowed in locality and remove high-priority intents for f3548_self_contained #389 in order for the CI to pass, so this other PR should be merged firstdone